A couple of bug fixes, and extract link icon function for general use

Tim Berners-Lee · Tim Berners-Lee · commit fe30f43e585a · 2016-08-30T14:38:51.000-04:00
diff --git a/lib/acl-control.js b/lib/acl-control.js
@@ -143,12 +143,14 @@ UI.aclControl.ACLControlBox5 = function (subject, dom, noun, kb, callback) {
       var ns = UI.ns
       var obj = $rdf.sym(uri)
       var types = kb.findTypeURIs(obj)
-      console.log('Drop object types: ' + types)
+      for (ty in types) {
+        console.log('    drop object type includes: ' + ty)
+      }
       if (uri.split('/').length === 4 && !(uri.split('/')[1]) && !(uri.split('/')[3])) {
         return {pred: 'origin', obj: obj} // The only way to know an origin alas
       }
       if (ns.vcard('WebID').uri in types) return {pred: 'agent', obj: obj}
-      
+
       if (ns.vcard('Group').uri in types) {
         return {pred: 'agentGroup', obj: obj} // @@ note vcard membership not RDFs
       }
@@ -167,6 +169,7 @@ UI.aclControl.ACLControlBox5 = function (subject, dom, noun, kb, callback) {
       if (ns.solid('AppProviderClass').uri in types) {
         return {pred: 'originClass', obj: obj}
       }
+      console.log('    Triage fails for ' + uri)
     }
 
     box.saveBack = function (callback) {
@@ -306,7 +309,6 @@ UI.aclControl.ACLControlBox5 = function (subject, dom, noun, kb, callback) {
           console.log('Drop event. dropEffect: ' + e.dataTransfer.dropEffect)
           console.log('Drop event. types: ' + (e.dataTransfer.types ? e.dataTransfer.types.join(', ') : 'NOPE'))
 
-          /** THIS IS THE MAGIC: we read from getData based on the content type - so it grabs the item matching that format **/
           var uris = null
           var text
           var thisEle = this
@@ -354,7 +356,7 @@ UI.aclControl.ACLControlBox5 = function (subject, dom, noun, kb, callback) {
                   if (!ok) {
                     console.log('Error looking up dropped thing ' + u + ': ' + mess)
                   } else {
-                    var res = agentTriage(u)
+                    res = agentTriage(u)
                     if (!res) {
                       console.log('Error: Drop fails to drop appropriate thing! ' + u)
                     } else {
diff --git a/lib/widgets.js b/lib/widgets.js
@@ -245,6 +245,19 @@ UI.widgets.makeDraggable = function(tr, obj){
   }, false)
 }
 
+
+// A little link icon
+//
+//
+UI.widgets.linkIcon = function(dom, subject, iconURI){
+  var anchor = dom.createElement('a')
+  anchor.setAttribute('href', subject.uri)
+  var linkIcon = anchor.appendChild(dom.createElement('img'))
+  linkIcon.setAttribute('src', iconURI || (UI.icons.originalIconBase + 'go-to-this.png'))
+  linkIcon.setAttribute('style','margin: 0.3em;')
+  return anchor
+}
+
 // A TR to repreent a draggable person, etc in a list
 //
 //
@@ -269,11 +282,8 @@ UI.widgets.personTR = function (dom, pred, obj, options) {
     UI.widgets.deleteButtonWithCheck(dom, td3, 'person', options.deleteFunction)
   }
   if (options.link !== false) {
-    var anchor = td3.appendChild(dom.createElement('a'))
-    anchor.setAttribute('href', obj.uri)
+    var anchor = td3.appendChild(UI.widgets.linkIcon(dom, obj))
     anchor.classList.add('HoverControlHide')
-    var linkImage = anchor.appendChild(dom.createElement('img'))
-    linkImage.setAttribute('src', UI.icons.originalIconBase + 'go-to-this.png')
     td3.appendChild(dom.createElement('br'))
   }
   if (options.draggable !== false) { // default is on
