Skip to content

feat: design qa multi theming improvements#2751

Open
auroraVasconcelos wants to merge 113 commits intomainfrom
feat/design-qa-multi-theming
Open

feat: design qa multi theming improvements#2751
auroraVasconcelos wants to merge 113 commits intomainfrom
feat/design-qa-multi-theming

Conversation

@auroraVasconcelos
Copy link
Copy Markdown
Contributor

@auroraVasconcelos auroraVasconcelos commented Jan 20, 2026

Description:

Closes #2787, closes #2739, closes #2789, closes #2740, closes #2815, closes #2805

  • Add css properties section to docs table in styles

To avoid breaking changes there are currently two types of fallbacks:

  • Newer tokens than components/styles (e.g., tokens on Solid v6.1.0 and components/styles on Solid v6.0.0):
    Fallbacks for removed variables are provided in variables-legacy.css.
  • Older tokens than components/styles (e.g., tokens on Solid v6.0.0 and components/styles on Solid v6.1.0):
    Additional fallbacks were introduced for CSS variables that support custom themes. These variables are marked as deprecated in the documentation, and users are encouraged to stop using them. They will be removed in a future version of Solid to ensure a more robust and maintainable codebase.

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 20, 2026

🦋 Changeset detected

Latest commit: f06ca95

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@solid-design-system/components" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@solid-design-system/styles" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@solid-design-system/tokens" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 20, 2026

🚀 Storybook has been deployed for branch feat_design-qa-multi-theming

@coraliefeil coraliefeil moved this from 📋 Backlog to 👀 In review in Solid Design System Project Board Jan 21, 2026
@coraliefeil
Copy link
Copy Markdown
Contributor

@van-nguyen-ht qa can be done as soon as chromatic is available. Let’s quickly talk when this is ready.

@coraliefeil
Copy link
Copy Markdown
Contributor

@auroraVasconcelos could we generate screenshots onto which we can put comments where adjustments need to be made?

coraliefeil
coraliefeil previously approved these changes Mar 24, 2026
smfonseca
smfonseca previously approved these changes Mar 24, 2026
@smfonseca smfonseca removed their assignment Mar 24, 2026
Copy link
Copy Markdown
Contributor

@mariohamann mariohamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still no fallbacks from what I see.

@auroraVasconcelos auroraVasconcelos dismissed MartaPintoTeixeira’s stale review March 25, 2026 19:23

Reviewed with Marta and approved by Coralie

@auroraVasconcelos
Copy link
Copy Markdown
Contributor Author

Still no fallbacks from what I see.

There are currently two types of fallbacks:

  • Newer tokens than components/styles (e.g., tokens on Solid v6.1.0 and components/styles on Solid v6.0.0):
    Fallbacks for removed variables are provided in variables-legacy.css.
  • Older tokens than components/styles (e.g., tokens on Solid v6.0.0 and components/styles on Solid v6.1.0):
    Additional fallbacks were introduced for CSS variables that support custom themes. These variables are marked as deprecated in the documentation, and users are encouraged to stop using them. They will be removed in a future version of Solid to ensure a more robust and maintainable codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

10 participants