feat: design qa multi theming improvements#2751
Open
auroraVasconcelos wants to merge 113 commits intomainfrom
Open
feat: design qa multi theming improvements#2751auroraVasconcelos wants to merge 113 commits intomainfrom
auroraVasconcelos wants to merge 113 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: f06ca95 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
Contributor
|
🚀 Storybook has been deployed for branch |
7 tasks
Contributor
|
@van-nguyen-ht qa can be done as soon as chromatic is available. Let’s quickly talk when this is ready. |
Contributor
|
@auroraVasconcelos could we generate screenshots onto which we can put comments where adjustments need to be made? |
coraliefeil
previously approved these changes
Mar 24, 2026
smfonseca
reviewed
Mar 24, 2026
smfonseca
previously approved these changes
Mar 24, 2026
mariohamann
requested changes
Mar 25, 2026
Contributor
mariohamann
left a comment
There was a problem hiding this comment.
Still no fallbacks from what I see.
mariohamann
reviewed
Mar 25, 2026
Reviewed with Marta and approved by Coralie
Contributor
Author
There are currently two types of fallbacks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Closes #2787, closes #2739, closes #2789, closes #2740, closes #2815, closes #2805
css propertiessection to docs table in stylesTo avoid breaking changes there are currently two types of fallbacks:
Fallbacks for removed variables are provided in variables-legacy.css.
Additional fallbacks were introduced for CSS variables that support custom themes. These variables are marked as deprecated in the documentation, and users are encouraged to stop using them. They will be removed in a future version of Solid to ensure a more robust and maintainable codebase.
Definition of Reviewable: