Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solid/solid-prep
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: solid/solid-prep
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: issue-1
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 3 files changed
  • 2 contributors

Commits on Oct 26, 2023

  1. chore: Bump actions/checkout 

    Update Github Actions to use actions/checkout v4 (previously v3).

Signed-off-by: Rahul Gupta <CxRes@users.noreply.github.com>
    @CxRes
    CxRes committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    70f29f3 View commit details
    Browse the repository at this point in the history

  2. feat: Add "Container only" triggers 

    Adds a new case for "Container only" triggers for PUT/PATCH methods being used to create a resource inside a container resulting in a 201 response.

Signed-off-by: Rahul Gupta <CxRes@users.noreply.github.com>
    @CxRes
    CxRes committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    923a0c6 View commit details
    Browse the repository at this point in the history

  3. feat: Add PUT/PATCH with 205 response as notification triggers 

    PUT and PATCH requests successfully modifying a resource may result in a 205 response and therefore SHOULD be notification triggers (See #1).

Signed-off-by: Rahul Gupta <CxRes@users.noreply.github.com>
    @CxRes
    CxRes committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f697d19 View commit details
    Browse the repository at this point in the history

  4. fix: Status Codes order for Resource only Triggers 

    Status code are now ordered numerically for the POST method in Resource only triggers.

Signed-off-by: Rahul Gupta <CxRes@users.noreply.github.com>
    @CxRes
    CxRes committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    28e7eee View commit details
    Browse the repository at this point in the history

  5. fix: POST should trigger container notifications 

         (unless creating child)

Unless POST is being used to create a child resource, it should also trigger the resource's parent container to send notifications.

Signed-off-by: Rahul Gupta <CxRes@users.noreply.github.com>
    @CxRes
    CxRes committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    8e9f521 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. typo: Punctuation in Triggers section 

    Add a missing indefinite article to "PREP notification".

Co-authored-by: Joachim Van Herwegen <joachimvh@gmail.com>
    @CxRes @joachimvh
    CxRes and joachimvh authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    c2674f7 View commit details
    Browse the repository at this point in the history

  2. refactor: Move Triggers to a Unified Table 

    Based on the discussions in PR #3, triggers have been combined into a single table for easier comprehension.

Signed-off-by: Rahul Gupta <CxRes@users.noreply.github.com>
    @CxRes
    CxRes committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    79f872c View commit details
    Browse the repository at this point in the history
Loading