Move to the new, official push-to-pantheon action#35
Merged
Conversation
wwahammy
force-pushed
the
try-new-pantheon-util
branch
from
ecfc684 to
3f819c9
Compare
wwahammy
changed the title
wwahammy
commented
May 20, 2025
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 |
Collaborator
Author
There was a problem hiding this comment.
The new github action doesn't like fetch-depth: 0 and will blow up. We don't normally use that in our checkouts so we should be fine removing it.
wwahammy
commented
May 20, 2025
Comment on lines
+31
to
+33
| deployments: write | ||
| contents: read | ||
| pull-requests: read |
Collaborator
Author
There was a problem hiding this comment.
This is required for the deployments and required by the new github action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pantheon has announced that they now have an official push to pantheon Github Action. There's no need to support our own action and the new one, while still a pre 1.0 release, is already more feature filled and boatload faster.
This has been tested on an internal repo at https://github.com/softwareforgood/softwareforgood.com/pull/636 and it's run successfully.
I propose we merge this and cut a new major version release for it; that way no repos automatically move to the new workflow.