refactor vsi create-option #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allmightyspiff
requested changes
Sep 10, 2020
Member
allmightyspiff
left a comment
allmightyspiff
left a comment
There was a problem hiding this comment.
Thanks, changes look mostly great, just a few minor changes to make this command perform better.
If we can get this command to stop using Virtual_Guest::getCreateObjectOptions it will actually respond quickly, which will be nice.
SoftLayer/CLI/virt/create_options.py
Outdated
|
|
||
|
|
||
| @click.command(short_help="Get options to use for creating virtual servers.") | ||
| @click.option('--vsi-type', required=False, type=click.Choice(['TRANSIENT', 'SUSPEND']), |
Member
There was a problem hiding this comment.
Add PUBLIC as a choice, and make it the default here, instead of in the cli command. Add show_default=True to the option.
allmightyspiff
approved these changes
Sep 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1334