Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sofarocean/sofar-api-client-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: sofarocean/sofar-api-client-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b/token_handling
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 3 files changed
  • 2 contributors

Commits on Oct 3, 2024

  1. Some initial fixes to the handling of tokens. 

    Likely incomplete- but I *think* this passes the token around correctly now.
    @pieterbartsmit @tcj
    pieterbartsmit authored and tcj committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a5db090 View commit details
    Browse the repository at this point in the history

  2. Some initial fixes to the handling of tokens. Specifically, we can no… 

    …w update the token on an instantiated SofarAPI object and it is respected in all subsequent uses of the API (including when passing it to a Spotter object).

Note that this pull also changes the default .env search logic from:

`look in user directory for sofer_api.env and load token from that`

To

`look in user directory for sofer_api.env and load token from that, if no file is present use default dotenv logic through find_dotenv()`

This preserves legacy behaviour- but otherwise moves towards more standard behaviour.
    @pieterbartsmit @tcj
    pieterbartsmit authored and tcj committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0ff10c8 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @tcj
    tcj committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2d3c7dc View commit details
    Browse the repository at this point in the history

  4. use token property instead of self._token

    @tcj
    tcj committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f99cba7 View commit details
    Browse the repository at this point in the history
Loading