Fix: mass binding is defined to have multiple inheritance#325
Merged
damienmarchal merged 1 commit intosofa-framework:masterfrom Dec 14, 2022
Merged
Conversation
Contributor
|
Here is what pybind docs says about that: So the PR is perfectly in the specified use case. |
alxbilger
added a commit
to alxbilger/SofaPython3
that referenced
this pull request
Dec 14, 2022
The multiple inheritance property of Mass has been identified problematic in a previous pull request sofa-framework#325. The test in this commit succeeds if Mass is defined with the label py::multiple_inheritance(). Otherwise it crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for https://github.com/sofa-framework/BeamAdapter/discussions/86
The call of
assembleKMatrixleads to a UB without the suggested change.