[Sofa.Prefab] Replace Sofa.Prefab "properties"#277
Merged
damienmarchal merged 2 commits intosofa-framework:masterfrom Jun 22, 2022
Merged
[Sofa.Prefab] Replace Sofa.Prefab "properties"#277damienmarchal merged 2 commits intosofa-framework:masterfrom
damienmarchal merged 2 commits intosofa-framework:masterfrom
Conversation
… "prefabData" The use of existing properties are not clear as useres tend to put both data & prefab properties (which trigger the update) To clarify that we split properties in two... one called prefabParameter and the other prefabData. A deprecation message is introduced when usnig "properties"
This was referenced Jun 21, 2022
alxbilger
reviewed
Jun 21, 2022
Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
hugtalbot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Sofa.Prefab "properties" by "prefabParameter" & "prefabData"
The use of existing properties are not clear as useres tend to put both data & prefab properties (which trigger the update)
To clarify that we split properties in two... one called prefabParameter and the other prefabData.
A deprecation message is introduced when usnig "properties"