Skip to content

[Binding/Sofa.Core] Update MechanicalObject Target in test #239

Merged
hugtalbot merged 2 commits intosofa-framework:masterfrom
fredroy:update_test_target_mechastate
Mar 30, 2022
Merged

[Binding/Sofa.Core] Update MechanicalObject Target in test #239
hugtalbot merged 2 commits intosofa-framework:masterfrom
fredroy:update_test_target_mechastate

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Mar 8, 2022 •
edited
Loading

To merge in the same time as sofa-framework/sofa#2766

@fredroy fredroy mentioned this pull request Mar 8, 2022
Merged
@guparan
Copy link
Contributor

guparan commented Mar 8, 2022 •
edited
Loading

1 unit test is failing @fredroy

[ RUN      ] SofaPython3/Sofa.all_tests/75_Sofa_Core_BaseObject_test_getTarget
======================================================================
FAIL: test_getTarget (BaseObject.Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "BaseObject.py", line 58, in test_getTarget
    self.assertEqual(c.getTarget(), 'Sofa.Component.Container')
AssertionError: 'SofaBaseMechanics' != 'Sofa.Component.Container'
- SofaBaseMechanics
+ Sofa.Component.Container


----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (failures=1)
/home/runner/work/SofaPython3/SofaPython3/artifact/bin/Bindings.Sofa.Tests.d/Core/BaseObject.py:0: Failure
Failed
[  FAILED  ] SofaPython3/Sofa.all_tests/75_Sofa_Core_BaseObject_test_getTarget, where GetParam() = /home/runner/work/SofaPython3/SofaPython3/artifact/bin/Bindings.Sofa.Tests.d/Core/BaseObject.py with args {test_getTarget, } (2 ms)

Looks like the test itself should be modified, am I right?

guparan
guparan suggested changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@guparan guparan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above 👍

guparan
guparan approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@guparan guparan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, this PR aims to fix a future change in SOFA (see sofa-framework/sofa#2766)

@fredroy fredroy mentioned this pull request Mar 28, 2022
Merged
@hugtalbot hugtalbot merged commit 6943590 into sofa-framework:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@guparan guparan guparan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: clean-fix pr: status ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fredroy @guparan @hugtalbot