Skip to content

[cmake] Add installation RPATH of SP3 target dependencies. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnbrunet merged 1 commit into from
Jun 26, 2020
Merged

[cmake] Add installation RPATH of SP3 target dependencies. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions CMake/SofaPython3Tools.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,47 @@ function(SP3_add_python_module)
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${SP3_PYTHON_PACKAGES_DIRECTORY}/${DESTINATION}"
)

# Note: This should be disabled if/when we will want to create packages
# Compute the installation RPATHs from the target's SP3 dependencies since they are not installed in a same directory
# and are not automatically added from the cmake option INSTALL_RPATH_USE_LINK_PATH.
# 1. Get all dependencies that are
# (a) a target in this project, and
# (b) built in CMAKE_LIBRARY_OUTPUT_DIRECTORY
# 2. Here we are sure that the dependency is a SP3 target and not an imported target from an external dependency.
# We compute its path relative to this target output file
# Ex: ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/site-packages/Sofa --> $ORIGIN/../Sofa
# 3. Add the relative path computed in 2 to the list of RPATHS
set(${A_TARGET}_DEPENDECIES_RPATH "${CMAKE_INSTALL_PREFIX}/${LIBRARY_OUTPUT_DIRECTORY}")
foreach(DEPENDENCY ${A_DEPENDS})
if (TARGET ${DEPENDENCY})
get_target_property(DEPENDENCY_LIBRARY_OUTPUT_DIRECTORY "${DEPENDENCY}" LIBRARY_OUTPUT_DIRECTORY)
if (NOT "${DEPENDENCY_LIBRARY_OUTPUT_DIRECTORY}" STREQUAL "")
file(RELATIVE_PATH dependency_path_from_packages "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${SP3_PYTHON_PACKAGES_DIRECTORY}" "${DEPENDENCY_LIBRARY_OUTPUT_DIRECTORY}")
if (NOT "${dependency_path_from_packages}" STREQUAL "" AND NOT "${dependency_path_from_packages}" STREQUAL "../")
list(APPEND ${A_TARGET}_DEPENDECIES_RPATH "$ORIGIN/../${dependency_path_from_packages}")
endif()
endif()
endif()
endforeach()

if (APPLE)
# In MacOS, the target dependency name is RPATH/site-packages/PackageName, so we need to add
# an RPATH to the directory that contains "site-paclages"
list(APPEND ${A_TARGET}_DEPENDECIES_RPATH "$ORIGIN/../..")
endif()

set_target_properties(
${A_TARGET}
PROPERTIES

# This option only works for target that are not defined by the SP3 project
# see https://stackoverflow.com/a/30400628 for details
INSTALL_RPATH_USE_LINK_PATH TRUE
INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/${LIBRARY_OUTPUT_DIRECTORY}"

# This will set the remaining RPATHs from our Bindings targets dependencies (install/lib/site-packages/*)
INSTALL_RPATH "${${A_TARGET}_DEPENDECIES_RPATH}"

# Don't use the installation RPATH for built files
BUILD_WITH_INSTALL_RPATH FALSE
)

if (APPLE)
Expand Down
7 changes: 6 additions & 1 deletion bindings/Sofa/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,16 @@ add_executable(${PROJECT_NAME} ${SOURCE_FILES} ${HEADER_FILES} ${PYTHON_FILES})
target_link_libraries(${PROJECT_NAME} SofaGTestMain SofaHelper SofaPython3::Plugin SofaPython3::Bindings.Sofa SofaPython3::Bindings.SofaTypes SofaPython3::Bindings.SofaRuntime)
target_compile_definitions(${PROJECT_NAME} PRIVATE "PYTHON_TESTFILES_DIR=\"${CMAKE_CURRENT_SOURCE_DIR}/\"")

set(RPATH "$ORIGIN/../lib")
if (APPLE)
list(APPEND RPATH "@executable_path/../lib")
endif()

set_target_properties(
${PROJECT_NAME}
PROPERTIES
INSTALL_RPATH_USE_LINK_PATH TRUE
INSTALL_RPATH "$ORIGIN/../lib"
INSTALL_RPATH "${RPATH}"
)

add_test(NAME ${PROJECT_NAME} COMMAND ${PROJECT_NAME})
Expand Down
9 changes: 7 additions & 2 deletions bindings/SofaRuntime/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,16 @@ add_executable(${PROJECT_NAME} ${SOURCE_FILES} ${PYTHON_FILES})
target_link_libraries(${PROJECT_NAME} SofaGTestMain SofaHelper SofaPython3::Plugin SofaPython3::Bindings.Sofa.Core)
target_compile_definitions(${PROJECT_NAME} PRIVATE "PYTHON_TESTFILES_DIR=\"${CMAKE_CURRENT_SOURCE_DIR}\"")

set(RPATH "$ORIGIN/../lib")
if (APPLE)
list(APPEND RPATH "@executable_path/../lib")
endif()

set_target_properties(
${PROJECT_NAME}
PROPERTIES
INSTALL_RPATH_USE_LINK_PATH TRUE
INSTALL_RPATH "$ORIGIN/../lib"
INSTALL_RPATH_USE_LINK_PATH TRUE
INSTALL_RPATH "${RPATH}"
)

add_test(NAME ${PROJECT_NAME} COMMAND ${PROJECT_NAME})
Expand Down
9 changes: 7 additions & 2 deletions bindings/SofaTypes/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,16 @@ add_executable(${PROJECT_NAME} ${SOURCE_FILES} ${PYTHON_FILES})
target_link_libraries(${PROJECT_NAME} SofaGTestMain SofaHelper SofaPython3::Plugin)
target_compile_definitions(${PROJECT_NAME} PRIVATE "PYTHON_TESTFILES_DIR=\"${CMAKE_CURRENT_SOURCE_DIR}/pyfiles/\"")

set(RPATH "$ORIGIN/../lib")
if (APPLE)
list(APPEND RPATH "@executable_path/../lib")
endif()

set_target_properties(
${PROJECT_NAME}
PROPERTIES
INSTALL_RPATH_USE_LINK_PATH TRUE
INSTALL_RPATH "$ORIGIN/../lib"
INSTALL_RPATH_USE_LINK_PATH TRUE
INSTALL_RPATH "${RPATH}"
)

add_test(NAME ${PROJECT_NAME} COMMAND ${PROJECT_NAME})
Expand Down