[cmake] Add installation RPATH of SP3 target dependencies.#19
Merged
jnbrunet merged 1 commit intosofa-framework:masterfrom Jun 26, 2020
jnbrunet:add_installation_rpath_sp3_dependencies
Merged
[cmake] Add installation RPATH of SP3 target dependencies.#19jnbrunet merged 1 commit intosofa-framework:masterfrom jnbrunet:add_installation_rpath_sp3_dependencies
jnbrunet merged 1 commit intosofa-framework:masterfrom
jnbrunet:add_installation_rpath_sp3_dependencies
Conversation
Merged
Contributor
|
Is this to review (the ci is failing) ? |
Contributor
Author
|
Yes sorry, forgot to rebase master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes link problem when trying to load SP3 from an installed package. It also fixes link problem from the tests executable in MacOS (this is required if we want a CI on MacOS).
Adding RPATHs is non-breaking, so this PR is pretty harmless.