Require Node.js 18 and use crypto.randomUUID() (#317)

jdufresne · auvipy · web-flow · commit c239289d8cd8 · 2026-05-04T13:05:38.000+06:00
* Require Node.js 18 and use crypto.randomUUID()

* Potential fix for pull request finding

* Update nvmrc and package-lock.json

---------

Co-authored-by: Asif Saif Uddin {"Auvi":"অভি"} &lt;auvipy@gmail.com&gt;
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-lts/erbium
+lts/hydrogen
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,7 @@
   This means you cannot use the same SockJS server installed at multiple prefixes.
   In practice this was confusing and not common.
   * `websocket` option is deprecated, but still respected. Please use       the new `transports` option.
-  * Node.js `>= 6.5.0` is required.
+  * Node.js `>= 18.0.0` is required.
 
 ## Other Fixes/Changes
   * Convert from coffeescript to ES6.
@@ -19,7 +19,7 @@
   * Added `detach(server)` function to remove SockJS from a HTTP server instance.
   * Update dependencies.
   * Examples have been updated to use latest versions of libraries.
-
+  * Remove the internal UUID helper and use Node.js `crypto.randomUUID()` directly.
 
 0.3.19
 ======
diff --git a/lib/sockjs-connection.js b/lib/sockjs-connection.js
@@ -1,14 +1,14 @@
 'use strict';
 
+const crypto = require('crypto');
 const debug = require('debug')('sockjs:connection');
 const stream = require('stream');
-const { uuid } = require('./utils');
 
 class SockJSConnection extends stream.Duplex {
   constructor(session) {
     super({ decodeStrings: false, encoding: 'utf8', readableObjectMode: true });
     this._session = session;
-    this.id = uuid();
+    this.id = crypto.randomUUID();
     this.headers = {};
     this.prefix = this._session.prefix;
     debug('new connection', this.id, this.prefix);
diff --git a/lib/utils.js b/lib/utils.js
@@ -2,36 +2,6 @@
 const crypto = require('crypto');
 const http = require('http');
 
-module.exports.uuid = function uuid() {
-  // only available on Node v16.7+
-  if (typeof crypto.randomUUID === 'function') {
-    return crypto.randomUUID();
-  }
-
-  const bytes = crypto.randomBytes(16);
-
-  // Per RFC 4122 §4.4:
-  // Set version to 4 => xxxx -> 0100
-  bytes[6] = (bytes[6] & 0x0f) | 0x40;
-
-  // Set variant to RFC 4122 => 10xxxxxx
-  bytes[8] = (bytes[8] & 0x3f) | 0x80;
-
-  const hex = bytes.toString('hex');
-
-  return (
-    hex.slice(0, 8) +
-    '-' +
-    hex.slice(8, 12) +
-    '-' +
-    hex.slice(12, 16) +
-    '-' +
-    hex.slice(16, 20) +
-    '-' +
-    hex.slice(20)
-  );
-};
-
 // used in case of 'upgrade' requests where res is
 // net.Socket instead of http.ServerResponse
 module.exports.fake_response = function fake_response(req, res) {
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -45,6 +45,6 @@
     "postpublish": "git push origin --all && git push origin --tags"
   },
   "engines": {
-    "node": ">=6.5.0"
+    "node": ">=18.0.0"
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,6 @@`
`45`	`45`	`"postpublish": "git push origin --all && git push origin --tags"`
`46`	`46`	`},`
`47`	`47`	`"engines": {`
`48`		`- "node": ">=6.5.0"`
	`48`	`+ "node": ">=18.0.0"`
`49`	`49`	`}`
`50`	`50`	`}`