[revert] Move binary detection to the parser

darrachequesne · darrachequesne · commit dc4f475a452f · 2018-02-28T21:55:26.000+01:00
So that we can skip the binary check.
diff --git a/index.js b/index.js
@@ -5,7 +5,6 @@
 
 var debug = require('debug')('socket.io-parser');
 var Emitter = require('component-emitter');
-var hasBin = require('has-binary2');
 var binary = require('./binary');
 var isArray = require('isarray');
 var isBuf = require('./is-buffer');
@@ -125,10 +124,6 @@ function Encoder() {}
  */
 
 Encoder.prototype.encode = function(obj, callback){
-  if ((obj.type === exports.EVENT || obj.type === exports.ACK) && hasBin(obj.data)) {
-    obj.type = obj.type === exports.EVENT ? exports.BINARY_EVENT : exports.BINARY_ACK;
-  }
-
   debug('encoding packet %j', obj);
 
   if (exports.BINARY_EVENT === obj.type || exports.BINARY_ACK === obj.type) {
diff --git a/is-buffer.js b/is-buffer.js
@@ -5,7 +5,7 @@ var withNativeBuffer = typeof global.Buffer === 'function' && typeof global.Buff
 var withNativeArrayBuffer = typeof global.ArrayBuffer === 'function';
 
 var isView = (function () {
-  if (typeof global.ArrayBuffer.isView === 'function') {
+  if (withNativeArrayBuffer && typeof global.ArrayBuffer.isView === 'function') {
     return global.ArrayBuffer.isView;
   } else {
     return function (obj) { return obj.buffer instanceof global.ArrayBuffer; };
diff --git a/package.json b/package.json
@@ -14,7 +14,6 @@
   "dependencies": {
     "debug": "~3.1.0",
     "component-emitter": "1.2.1",
-    "has-binary2": "~1.0.2",
     "isarray": "2.0.1"
   },
   "devDependencies": {
