Update websocketpp to e036a5au to fix compilation under Arch and Ubuntu 17.10 #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under Arch Linux (and Ubuntu 17.10 according to socketio#196), compilation fails with an error in websocketpp: "error: no matching function for call to ‘make_shared(std::reference_wrapper<boost::asio::io_context>)’". To resolve this, update websocketpp to e036a5au which is the first revision after ac5d7ea5 which compiles without warnings being generated. Fixes socketio#196.
Author
|
Looks like there is an issue with the travis build at the moment which isn't related to this change... |
Author
Thanks for the heads-up 👍. I've subscribed to updates on your PR #214 so if the maintainers decide to merge yours (bring all submodules right up-to-date) in preference to mine (just update websocketpp to the first commit which fixes the build) I can close this PR 😄. |
|
I have this issue in openSUSE Tumbleweed as well. Also solved by Thanks to @syncu2! It is strange why git submodule reference to |
Member
|
Included in af68bf3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Arch Linux (and Ubuntu 17.10 according to #196), compilation fails with an error in websocketpp:
error: no matching function for call to ‘make_shared(std::reference_wrapper<boost::asio::io_context>)’.To resolve this, update websocketpp to zaphoyd/websocketpp@e036a5a which is the first revision after the current zaphoyd/websocketpp@ac5d7ea5 which compiles without warnings.