Skip to content

fix: prevent crash when accessing TextDecoder#684

Merged
darrachequesne merged 1 commit into
socketio:mainfrom
iowaguy:main
Jun 27, 2023
Merged

fix: prevent crash when accessing TextDecoder#684
darrachequesne merged 1 commit into
socketio:mainfrom
iowaguy:main

Conversation

@iowaguy
Copy link
Copy Markdown
Contributor

@iowaguy iowaguy commented Jun 26, 2023

This bug was introduced in [1] and included in release 6.5.0.

[1] 123b68c

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

The TextDecoder object was never imported before being used. This is the cause of #683.

New behaviour

Adding the dependency stops the crash from occuring.

Other information (e.g. related issues)

The TextDecoder object was never imported before being used. This bug was introduced in [1]
and included in release 6.5.0.

[1] 123b68c
@darrachequesne darrachequesne merged commit 6dd2bc4 into socketio:main Jun 27, 2023
@darrachequesne
Copy link
Copy Markdown
Member

Thanks! Released in version 6.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants