Design review: Explicitly disable TypeNameHandling in all Json.NET usage

SteveSandersonMS · SteveSandersonMS · commit 465d0c8d1582 · 2016-09-07T17:12:01.000+01:00
diff --git a/src/Microsoft.AspNetCore.NodeServices/HostingModels/HttpNodeInstance.cs b/src/Microsoft.AspNetCore.NodeServices/HostingModels/HttpNodeInstance.cs
@@ -25,9 +25,10 @@ internal class HttpNodeInstance : OutOfProcessNodeInstance
         private static readonly Regex PortMessageRegex =
             new Regex(@"^\[Microsoft.AspNetCore.NodeServices.HttpNodeHost:Listening on port (\d+)\]$");
 
-        private static readonly JsonSerializerSettings JsonSerializerSettings = new JsonSerializerSettings
+        private static readonly JsonSerializerSettings jsonSerializerSettings = new JsonSerializerSettings
         {
-            ContractResolver = new CamelCasePropertyNamesContractResolver()
+            ContractResolver = new CamelCasePropertyNamesContractResolver(),
+            TypeNameHandling = TypeNameHandling.None
         };
 
         private readonly HttpClient _client;
@@ -58,7 +59,7 @@ private static string MakeCommandLineOptions(int port)
 
         protected override async Task<T> InvokeExportAsync<T>(NodeInvocationInfo invocationInfo)
         {
-            var payloadJson = JsonConvert.SerializeObject(invocationInfo, JsonSerializerSettings);
+            var payloadJson = JsonConvert.SerializeObject(invocationInfo, jsonSerializerSettings);
             var payload = new StringContent(payloadJson, Encoding.UTF8, "application/json");
             var response = await _client.PostAsync("http://localhost:" + _portNumber, payload);
 
@@ -85,7 +86,7 @@ protected override async Task<T> InvokeExportAsync<T>(NodeInvocationInfo invocat
 
                 case "application/json":
                     var responseJson = await response.Content.ReadAsStringAsync();
-                    return JsonConvert.DeserializeObject<T>(responseJson);
+                    return JsonConvert.DeserializeObject<T>(responseJson, jsonSerializerSettings);
 
                 case "application/octet-stream":
                     // Streamed responses have to be received as System.IO.Stream instances
diff --git a/src/Microsoft.AspNetCore.NodeServices/HostingModels/SocketNodeInstance.cs b/src/Microsoft.AspNetCore.NodeServices/HostingModels/SocketNodeInstance.cs
@@ -29,7 +29,8 @@ internal class SocketNodeInstance : OutOfProcessNodeInstance
     {
         private readonly static JsonSerializerSettings jsonSerializerSettings = new JsonSerializerSettings
         {
-            ContractResolver = new CamelCasePropertyNamesContractResolver()
+            ContractResolver = new CamelCasePropertyNamesContractResolver(),
+            TypeNameHandling = TypeNameHandling.None
         };
 
         private readonly SemaphoreSlim _connectionCreationSemaphore = new SemaphoreSlim(1);

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ internal class SocketNodeInstance : OutOfProcessNodeInstance`
`29`	`29`	`{`
`30`	`30`	`private readonly static JsonSerializerSettings jsonSerializerSettings = new JsonSerializerSettings`
`31`	`31`	`{`
`32`		`- ContractResolver = new CamelCasePropertyNamesContractResolver()`
	`32`	`+ ContractResolver = new CamelCasePropertyNamesContractResolver(),`
	`33`	`+ TypeNameHandling = TypeNameHandling.None`
`33`	`34`	`};`
`34`	`35`
`35`	`36`	`private readonly SemaphoreSlim _connectionCreationSemaphore = new SemaphoreSlim(1);`