Skip to content

Make this loadable easily by ZSH frameworks - #482

Merged
scottchiefbaker merged 1 commit into
so-fancy:nextfrom
unixorn:add-zsh-framework-support
Feb 26, 2024
Merged

Make this loadable easily by ZSH frameworks#482
scottchiefbaker merged 1 commit into
so-fancy:nextfrom
unixorn:add-zsh-framework-support

Conversation

@unixorn

@unixorn unixorn commented Feb 24, 2024

Copy link
Copy Markdown
Contributor

Let zsh users with frameworks use the framework to automatically clone the repostitory and add it to their $PATH so that the frameworks can keep the git checkout up to date.

@scottchiefbaker

scottchiefbaker commented Feb 24, 2024

Copy link
Copy Markdown
Contributor

I don't know a whole lot about zsh but I support this effort.

Have you looked at the zsh stuff in the pro tips documentation? Is there any overlap there? If you want to move your stuff to the protips docs instead of the main README I'll land this code.

@unixorn

unixorn commented Feb 25, 2024

Copy link
Copy Markdown
Contributor Author

I'll update the doc there, then people can use dsf directly as a plugin without hassling with submodules. I think it's cleaner to have the framework support integrated in the tool repo.

Add repo's gitroot to `$PATH` so it can be loaded easily by ZSH frameworks.

Signed-off-by: Joe Block <jpb@unixorn.net>
@unixorn
unixorn force-pushed the add-zsh-framework-support branch from f362e6e to bc8485e Compare February 26, 2024 15:15
@unixorn

unixorn commented Feb 26, 2024

Copy link
Copy Markdown
Contributor Author

Updated the doc per your suggestion & updated diff-so-fancy.plugin.zsh to conform better to the ZSH plugin standard.

@scottchiefbaker
scottchiefbaker merged commit 578bffc into so-fancy:next Feb 26, 2024
@unixorn
unixorn deleted the add-zsh-framework-support branch February 26, 2024 16:17
@unixorn

unixorn commented Feb 26, 2024

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants