Matrix allocation optimization#321
Open
DanielLacina wants to merge 2 commits intosmartcorelib:developmentfrom
Open
Matrix allocation optimization#321DanielLacina wants to merge 2 commits intosmartcorelib:developmentfrom
DanielLacina wants to merge 2 commits intosmartcorelib:developmentfrom
Conversation
Contributor
Author
|
This is not finished but I in order to use the MatrixPool, the Dense Matrix could only accept types that have static lifetimes. |
Contributor
Author
|
There's some situations where if you pass in borrowed values , the static lifetime condition is not satisifed. |
Collaborator
|
i don't think this is the right way to go. |
Contributor
Author
|
Ok |
Collaborator
|
or at least we need a multi-step roadmap to gradually implement this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.