Rust: Fix two way binding to different structs #9935
Merged
+59
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
force-pushed
the
olivier/properties2
branch
from
3e49be2 to
6f5cb00
Compare
This line was added by mistake in a previous commit. But the feature can't work for C++ and the interpreter for now because they can't re-use the same binding. It would also break for eust if there was another layer of two way binding. That's because `impl BindingCallable for TwoWayBindingWithMap` doesn't (and can't) implement intercept_set_binding
ogoffart
force-pushed
the
olivier/properties2
branch
from
6f5cb00 to
4b6c8ea
Compare
ogoffart
changed the title
tronical
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line was added by mistake in a previous commit.
But the feature can't work for C++ and the interpreter for now because they can't re-use the same binding.
It would also break for eust if there was another layer of two way binding.
That's because
impl BindingCallable for TwoWayBindingWithMapdoesn't (and can't) implement intercept_set_binding