Forward private base references used as property defaults - #12865
Forward private base references used as property defaults#12865R-Cramer4 wants to merge 2 commits into
Conversation
ogoffart
left a comment
There was a problem hiding this comment.
Clever to create a property that alias the original.
This will show up in errors such as the binding loop error, but i guess this is fine as it is a corner case.
@LeonMatthes will that also help for the debug hook to have debug hook on property that don't have a binding in the component itself but have a binding in the element?
|
(An alternative implementation could be to have an extra property for the "base" case, but not sure it is a nicer implementenation) |
I don't think so. We don't debug hook the base component of the elements anyway, only the root components elements. |
Ah, actually, I think I know what you were getting at. We could use the same mechanism for injecting debug hooks that references something from the base component. On the other hand, how difficult do you think it would be to make the But in any case, if we merge this PR as-is, I'll try to move the debug hooks over to this as well. |
I think more difficult. But that would also be a fix for #12881 |
Closes #1461
This fix creates a new property on the base element during lowering so it can be accessed by other elements