Update phpstan to 0.10#63
Closed
danopz wants to merge 1 commit into
Closed
Conversation
danopz
commented
Sep 20, 2018
danopz
commented
Member
- updated phpstan
- fixed some logged errors
- on travis its only installed for php 7.1
Member
|
After pulling the branch and running |
Member
Author
|
I removed phpstan from require-dev as we are on php >=7.0, but phpstan 0.10 requires phpstan ~7.1, so it would fail on the 7.0 test. I'm just installing it for Travis @ php 7.1. Edit: Maybe directly close as obsolete because of #67? |
Member
|
PHPStan is now implemented. |
danopz
added a commit
to danopz/Slim-Psr7
that referenced
this pull request
Nov 1, 2018
… 7.1 on travis, port of slimphp/Slim-Http#63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.