Fixed integration tests for UploadedFile, Uri#54
Merged
Conversation
danopz
changed the title
Member
Author
|
@akrabat would you may have a look? This one makes other PRs red |
Member
|
Running the tests results in a |
akrabat
added a commit
that referenced
this pull request
Sep 8, 2018
Member
|
I added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After php-http/psr7-integration-tests finally added some tests for UploadedFile I checked if we are compatible and found out that our test setup of the UploadedFile was wrong, which ended in errors running PHPUnit.
Now the tests should be running fine.
Edit:
With latest updates Uri integration tests were failing too.