Add support for psr/http-message ^2.0#3302
Merged
l0gicgate merged 3 commits intoslimphp:4.xfrom Dec 14, 2023
Merged
Conversation
…quirement-bump-up
|
composer require slim/psr7 Problem 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed psr/http-message requirement to ^1.1 || ^2.0 in composer.json.
Note that in dev environment (ie. cloning this repo with this pull request merged and running the tests in PHP 7.4) psr/http-message ^1.1 always gets pulled in by composer for PHP 7.4 users because PSR 7 implementations like laminas/laminas-diactoros ^2.17 in the require-dev section of https://github.com/slimphp/Slim/blob/4.x/composer.json requires psr/http-message ^1.0.
For users requiring slim/slim in their applications and using a PSR 7 implementation like nyholm/psr7 ^1.8 which requires psr/http-message ^1.1 || ^2.0 ( https://github.com/Nyholm/psr7/blob/1.8.1/composer.json ), psr/http-message ^2.0 will be pulled in for those applications.
Closes #3296