Skip to content

Added test_md5sum.cpp #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Added test_md5sum.cpp #3389

wants to merge 4 commits into from

Conversation

@singhpratik5
Copy link
Contributor

@singhpratik5 singhpratik5 commented Oct 19, 2025

test file added for md5_sum.cpp of hashdb directory

@codecov
Copy link

codecov bot commented Oct 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 87.22467% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.24%. Comparing base (4bda7cd) to head (3782c22).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
test/tsk/hashdb/test_md5sum.cpp 87.22% 29 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3389      +/-   ##
===========================================
+ Coverage    31.64%   32.24%   +0.60%     
===========================================
  Files          192      193       +1     
  Lines        43149    43376     +227     
===========================================
+ Hits         13653    13985     +332     
+ Misses       29496    29391     -105
Flag Coverage Δ
unittests 32.24% <87.22%> (+0.60%) ⬆️
windows-mingw 32.24% <87.22%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/tsk/hashdb/test_md5sum.cpp 87.22% <87.22%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simsong
Copy link
Member

simsong commented Oct 19, 2025

Great work. I wonder why the WIN32 code is not running through codecov...

@simsong
Copy link
Member

simsong commented Oct 20, 2025

Found a problem: Several of the disk images can't be ofund.

https://github.com/sleuthkit/sleuthkit/actions/runs/18637808154/job/53131430466


../test/tsk/fs/test_dls_lib.cpp:18: warning:
  Ext2 test image not found, skipping filesystem tests

-------------------------------------------------------------------------------
dls_lib: tsk_fs_blkls with LIST flag
-------------------------------------------------------------------------------
../test/tsk/fs/test_dls_lib.cpp:59
...............................................................................

../test/tsk/fs/test_dls_lib.cpp:18: warning:
  Ext2 test image not found, skipping filesystem tests

ffs_jblk_walk_unsupported

../test/tsk/fs/test_ffs.cpp:64
...............................................................................

../test/tsk/fs/test_ffs.cpp:67: warning:
Could not open FFS image. Skipping test.

ffs_jopen_unsupported

../test/tsk/fs/test_ffs.cpp:79
...............................................................................

../test/tsk/fs/test_ffs.cpp:82: warning:
Could not open FFS image. Skipping test.

@singhpratik5
Copy link
Contributor Author

singhpratik5 commented Oct 20, 2025

Found a problem: Several of the disk images can't be ofund.

https://github.com/sleuthkit/sleuthkit/actions/runs/18637808154/job/53131430466


../test/tsk/fs/test_dls_lib.cpp:18: warning:
  Ext2 test image not found, skipping filesystem tests

-------------------------------------------------------------------------------
dls_lib: tsk_fs_blkls with LIST flag
-------------------------------------------------------------------------------
../test/tsk/fs/test_dls_lib.cpp:59
...............................................................................

../test/tsk/fs/test_dls_lib.cpp:18: warning:
  Ext2 test image not found, skipping filesystem tests

ffs_jblk_walk_unsupported

../test/tsk/fs/test_ffs.cpp:64 ...............................................................................

../test/tsk/fs/test_ffs.cpp:67: warning: Could not open FFS image. Skipping test.

ffs_jopen_unsupported

../test/tsk/fs/test_ffs.cpp:79 ...............................................................................

../test/tsk/fs/test_ffs.cpp:82: warning: Could not open FFS image. Skipping test.

Exactly, don't know why unable to use the disk images at cloud.

@singhpratik5
Copy link
Contributor Author

singhpratik5 commented Oct 20, 2025

Great work. I wonder why the WIN32 code is not running through codecov...
Skipping them as they are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@singhpratik5 @simsong