This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Merged
Conversation
Basically just save an `embed` elsewhere, but 🤷♂️
kritzcreek
suggested changes
Jul 26, 2018
kritzcreek
left a comment
kritzcreek
left a comment
There was a problem hiding this comment.
Looks good, just seems like one typo
| path ← Pt.parseAnyDirPath P.fail s | ||
| pure $ Sig.Import path | ||
|
|
||
| variable ∷ ∀ m t. SqlParser' m t |
Member
Author
|
Oops! Should be good now. |
kritzcreek
approved these changes
Jul 27, 2018
cryogenian
reviewed
Jul 27, 2018
Member
cryogenian
left a comment
cryogenian
left a comment
There was a problem hiding this comment.
Non-blocking but good to have comment about moving genIdent :)
src/SqlSquared/Signature.purs
Outdated
| genImport = map Import Pt.genAnyDirPath | ||
|
|
||
| genIdent ∷ ∀ m. Gen.MonadGen m ⇒ m String | ||
| genIdent ∷ ∀ m. Gen.MonadGen m ⇒ m ID.Ident |
Member
There was a problem hiding this comment.
This should live in SqlSquared.Signature.Ident I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of things @kritzcreek and I encountered while working on SQL generation that could be tweaked for a better experience.