This repository was archived by the owner on Jun 15, 2023. It is now read-only.
[qz-3635] Correct precedence when parsing join conditions#43
Merged
garyb merged 1 commit intoslamdata:masterfrom Feb 2, 2018
Merged
[qz-3635] Correct precedence when parsing join conditions#43garyb merged 1 commit intoslamdata:masterfrom
garyb merged 1 commit intoslamdata:masterfrom
Conversation
Member
|
@wemrysi this looks good to me - I assume the change is to match the way it parses in Quasar? |
Contributor
Author
|
@garyb Yeah, both were wrong and the Quasar parser was fixed in quasar-analytics/quasar#3452 so this is just applying the same fix here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the parsing of join conditions so that queries like
parse correctly. Prior to this fix the
limitwould be considered part of the join condition and not the outer query.