This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Missed some bits of MonadGen conversion#37
Merged
garyb merged 1 commit intoslamdata:masterfrom Oct 31, 2017
Merged
Conversation
safareli
reviewed
Oct 31, 2017
| arbitrarySqlModuleOfSize = traverse arbitrarySqlOfSize <=< Sig.arbitrarySqlModuleF | ||
| genSqlModule ∷ ∀ m. Gen.MonadGen m ⇒ MonadRec m ⇒ m SqlModule | ||
| genSqlModule = | ||
| Gen.sized $ traverse (flip Gen.resize genSql <<< const) <=< Sig.genSqlModuleF |
Contributor
There was a problem hiding this comment.
Will (_ `Gen.resize` genSql <<< const) work here? (I find _ easier to read than flip)
Member
Author
There was a problem hiding this comment.
You'd need some more parens ((_ `Gen.resize` genSql) <<< const) which probably tips it into being worse than using flip again, I think. It's syntactically valid without the parens, but means _ `Gen.Resize` (genSql <<< const) if you don't include them, so it fails to typecheck instead... a little weird!
safareli
approved these changes
Oct 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.