Skip to content

Migrate to using golang.org/x/sys/unix over syscall - #74

Open
bored-engineer wants to merge 1 commit into
slackhq:masterfrom
bored-engineer:xsysunix
Open

Migrate to using golang.org/x/sys/unix over syscall#74
bored-engineer wants to merge 1 commit into
slackhq:masterfrom
bored-engineer:xsysunix

Conversation

@bored-engineer

@bored-engineer bored-engineer commented Apr 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

The "syscall" package used by go-audit has been frozen since Go 1.4:

Deprecated: this package is locked down. Callers should use the corresponding package in the golang.org/x/sys repository instead. That is also where updates required by new systems or versions should be applied. See https://golang.org/s/go1.4-syscall for more information.

This PR migrates to using golang.org/x/sys/unix instead as new fixes/features are implemented there.

Related Issues

Closes #73

Test strategy

go build succeeds without errors
go test passes

@CLAassistant

CLAassistant commented Apr 18, 2020 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@bored-engineer

bored-engineer commented Apr 18, 2020

Copy link
Copy Markdown
Contributor Author

Sorry for the force pushes, had to fix the emails in the commit to match the CLA email I used

@codecov-io

codecov-io commented Apr 26, 2020

Copy link
Copy Markdown

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is 84.21%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   64.09%   64.09%           
=======================================
  Files           7        7           
  Lines         596      596           
=======================================
  Hits          382      382           
  Misses        193      193           
  Partials       21       21
Impacted Files Coverage Δ
client.go 89.23% <80.00%> (ø)
audit.go 74.58% <100.00%> (ø)
marshaller.go 52.43% <100.00%> (ø)
parser.go 89.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75218d0...204af48. Read the comment docs.

@ghost

ghost commented Oct 26, 2021

Copy link
Copy Markdown

@wadey is there the possibility that this pull request can be merged?

@psanford

psanford commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

I'm unclear as to what problem this is solving. While it is true that syscall is a frozen API, it has the necessary netlink APIs to get kernel audit data. The syscall package still gets bug fixes, it is just not getting new API additions.

@ghost

ghost commented Oct 26, 2021

Copy link
Copy Markdown

Thank you for the clarification why it is not merged.

@codecov-commenter

codecov-commenter commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.09%. Comparing base (75218d0) to head (204af48).
⚠️ Report is 71 commits behind head on master.

Files with missing lines Patch % Lines
client.go 80.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   64.09%   64.09%           
=======================================
  Files           7        7           
  Lines         596      596           
=======================================
  Hits          382      382           
  Misses        193      193           
  Partials       21       21

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate from "syscall" to "golang.org/x/sys/unix"

5 participants

@bored-engineer @CLAassistant @codecov-io @psanford @codecov-commenter