Skip to content

Setting a default value for select_options for ViewStateValue #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 1 commit into from
Apr 2, 2021
Merged

Setting a default value for select_options for ViewStateValue #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions slack_sdk/models/views/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,13 @@ def __init__(
self.selected_conversations = selected_conversations
self.selected_channels = selected_channels
self.selected_users = selected_users
if selected_options:
if isinstance(selected_options, dict):
self.selected_options = [Option(**d) for d in selected_options]
else:
self.selected_options = selected_options

if isinstance(selected_options, list):
self.selected_options = []
for option in selected_options:
if isinstance(option, Option):
self.selected_options.append(option)
elif isinstance(option, dict):
self.selected_options.append(Option(**option))
else:
self.selected_options = selected_options
38 changes: 38 additions & 0 deletions tests/slack_sdk/models/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,44 @@ def test_all_state_values(self):
self.assertDictEqual(expected, ViewState(**expected).to_dict())
self.assertDictEqual(expected, state.to_dict())

def test_view_state_value_empty_selected_options(self):
input = {
'type': 'checkboxes',
'selected_options': []
}

view_state_value = ViewStateValue(**input)
assert view_state_value.selected_options == []

def test_view_state_value_with_selected_options(self):
expected = {
"type": "checkboxes",
"selected_options": [
{
"text": {
"type": "plain_text",
"text": "test_option_text"
},
"value": "test_option_value"
}
],
}

input = {
"type": "checkboxes",
"selected_options": [
{
"text": {
"type": "plain_text",
"text": "test_option_text"
},
"value": "test_option_value"
}
]
}

self.assertDictEqual(expected, ViewStateValue(**input).to_dict())

def test_load_modal_view_001(self):
with open("tests/slack_sdk_fixture/view_modal_001.json") as file:
self.verify_loaded_view_object(file)
Expand Down