Skip to content

Setting a default value for select_options for ViewStateValue#988

Merged
seratch merged 1 commit intoslackapi:mainfrom
scott-shields-github:sshields_adding_deault_attribute
Apr 2, 2021
Merged

Setting a default value for select_options for ViewStateValue#988
seratch merged 1 commit intoslackapi:mainfrom
scott-shields-github:sshields_adding_deault_attribute

Conversation

@scott-shields-github
Copy link
Contributor

@scott-shields-github scott-shields-github commented Apr 2, 2021

Summary

This pull request adds a default selected_options attribute for ViewStateValue objects. This makes it consistent with the other attributes of this class. This is related to Issue 987.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@gitwave gitwave bot added the untriaged label Apr 2, 2021
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@seratch seratch added this to the 3.5.0 milestone Apr 2, 2021
@seratch
Copy link
Contributor

seratch commented Apr 2, 2021

@scott-shields-github Thanks a lot for taking the time to make this pull request! The changes already look good to me 👍 but would you mind signing our CLA? Refer to the above comment by the CLA assistant bot for details 🙇

seratch
seratch suggested changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI build failures should not be related to your change. Please consider signing our CLA 🙇

@scott-shields-github
Copy link
Contributor Author

scott-shields-github commented Apr 2, 2021

Hi @seratch I signed the CLA yesterday, but it appears to be pending. When I follow the link now it just shows all of my information, including the checked approval box, without a submit button.

@seratch
Copy link
Contributor

seratch commented Apr 2, 2021

@scott-shields-github as the bot says, perhaps the email address you used for the git commit is not associated with your github account.

@scott-shields-github scott-shields-github force-pushed the sshields_adding_deault_attribute branch from 0a917a6 to be2190c Compare April 2, 2021 11:22
@scott-shields-github
Copy link
Contributor Author

scott-shields-github commented Apr 2, 2021

Ah, I see what happened. I accidentally pushed with the wrong email. Should be all set now. Thanks!

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #988 (be2190c) into main (83c6f9c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
+ Coverage   87.26%   87.28%   +0.01%     
==========================================
  Files          94       94              
  Lines        8591     8595       +4     
==========================================
+ Hits         7497     7502       +5     
+ Misses       1094     1093       -1
Impacted Files Coverage Δ
slack_sdk/models/views/__init__.py 91.73% <100.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c6f9c...be2190c. Read the comment docs.

@seratch seratch merged commit 223b285 into slackapi:main Apr 2, 2021
@seratch seratch mentioned this pull request Apr 2, 2021
Closed
@scott-shields-github scott-shields-github deleted the sshields_adding_deault_attribute branch April 2, 2021 12:13
@seratch seratch mentioned this pull request Apr 10, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@seratch seratch seratch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Version: 3x web-client

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@scott-shields-github @CLAassistant @seratch