Add fallback argument in BlockAttachment#979
Merged
seratch merged 1 commit intoslackapi:mainfrom Mar 22, 2021
Merged
Conversation
seratch
added
bug
Codecov Report
@@ Coverage Diff @@
## main #979 +/- ##
==========================================
+ Coverage 87.31% 87.34% +0.02%
==========================================
Files 94 94
Lines 8541 8543 +2
==========================================
+ Hits 7458 7462 +4
+ Misses 1083 1081 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The attachments document encourages having
fallbackfield in each attachment: https://api.slack.com/reference/messaging/attachments#legacy_fieldsThis pull request resolves the missing
fallbackargument inBlockAttachmentconstructor.Thanks @eddyg for the feedback: https://community.slack.com/archives/CHL4CLRCZ/p1616013860007200
(if you're interested in joining the Slack workspace, you can join the community from https://j.mp/community-slack-com)
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./docs.sh?)/docs-src-v2(Documents, have you run./docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python setup.py validateafter making the changes.