Skip to content

Add unknown kwargs in SCIM / Audit Logs clients#944

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:unknown-kwargs
Feb 4, 2021
Merged

Add unknown kwargs in SCIM / Audit Logs clients#944
seratch merged 1 commit intoslackapi:mainfrom
seratch:unknown-kwargs

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Feb 4, 2021

Summary

This pull request applies improvements to the data classes in #940 #936 . Without this change, the JSON response data parser fails when the server-side introduces a new field to the data structure.

Category (place an x in each of the [ ])

  • slack_sdk.audit_logs (sync/async) (Web API client)
  • slack_sdk.scim (sync/async) (Web API client)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x scim-client audit-logs-client labels Feb 4, 2021
@seratch seratch added this to the 3.3.0 milestone Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #944 (53f9710) into main (77328c1) will increase coverage by 0.15%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
+ Coverage   85.18%   85.34%   +0.15%     
==========================================
  Files          67       67              
  Lines        5860     5902      +42     
==========================================
+ Hits         4992     5037      +45     
+ Misses        868      865       -3
Impacted Files Coverage Δ
slack_sdk/scim/v1/user.py 88.39% <83.33%> (+5.05%) ⬆️
slack_sdk/audit_logs/v1/logs.py 77.33% <84.61%> (+0.80%) ⬆️
slack_sdk/scim/v1/group.py 87.80% <85.71%> (-0.77%) ⬇️
slack_sdk/scim/v1/internal_utils.py 90.47% <100.00%> (ø)
slack_sdk/scim/v1/types.py 100.00% <100.00%> (ø)
slack_sdk/scim/v1/response.py 88.94% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77328c1...53f9710. Read the comment docs.

@seratch seratch merged commit e31d734 into slackapi:main Feb 4, 2021
@seratch seratch deleted the unknown-kwargs branch February 4, 2021 05:25
@seratch seratch mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

audit-logs-client bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented scim-client Version: 3x

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

1 participant

@seratch