Skip to content

Fix #437 Add SCIM API Support#940

Merged
seratch merged 5 commits intoslackapi:mainfrom
seratch:issue-437-scim
Feb 3, 2021
Merged

Fix #437 Add SCIM API Support#940
seratch merged 5 commits intoslackapi:mainfrom
seratch:issue-437-scim

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Feb 1, 2021

Summary

This pull request fixes #437 by adding SCIM API support.

https://api.slack.com/scim

Category (place an x in each of the [ ])

  • slack_sdk.scim.SCIMClient (sync/async) (Web API client)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality Version: 3x labels Feb 1, 2021
@seratch seratch added this to the 3.3.0 milestone Feb 1, 2021
@seratch seratch self-assigned this Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021 •
edited
Loading

Codecov Report

Merging #940 (1c78c17) into main (b79dd77) will increase coverage by 0.28%.
The diff coverage is 88.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
+ Coverage   86.08%   86.37%   +0.28%     
==========================================
  Files          57       66       +9     
  Lines        4995     5643     +648     
==========================================
+ Hits         4300     4874     +574     
- Misses        695      769      +74
Impacted Files Coverage Δ
slack_sdk/scim/async_client.py 0.00% <0.00%> (ø)
slack_sdk/web/legacy_client.py 96.61% <82.60%> (-0.48%) ⬇️
slack_sdk/scim/v1/user.py 83.33% <83.33%> (ø)
slack_sdk/scim/v1/response.py 86.84% <86.84%> (ø)
slack_sdk/scim/v1/group.py 88.57% <88.57%> (ø)
slack_sdk/scim/v1/internal_utils.py 90.47% <90.47%> (ø)
slack_sdk/scim/v1/client.py 91.00% <91.00%> (ø)
slack_sdk/scim/v1/async_client.py 93.81% <93.81%> (ø)
slack_sdk/scim/v1/default_arg.py 100.00% <100.00%> (ø)
slack_sdk/scim/v1/types.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd4c78...1c78c17. Read the comment docs.

stevengill
stevengill approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Very thorough. I like how you added all of the different response types too!

For some reason I always thought to add SCIM support meant extending the webclient, but I like your approach to keep it a separate package.

@seratch seratch merged commit 19eedad into slackapi:main Feb 3, 2021
@seratch seratch deleted the issue-437-scim branch February 3, 2021 22:37
This was referenced Feb 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevengill stevengill stevengill approved these changes

@mwbrooks mwbrooks Awaiting requested review from mwbrooks

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality Version: 3x

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

Add SCIM API Support

2 participants

@seratch @stevengill