Skip to content

Fix #782 Audit Logs API support#936

Merged
seratch merged 9 commits intoslackapi:mainfrom
seratch:issue-782-audit-logs
Feb 2, 2021
Merged

Fix #782 Audit Logs API support#936
seratch merged 9 commits intoslackapi:mainfrom
seratch:issue-782-audit-logs

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Jan 30, 2021

Summary

This pull request adds Audit Logs API support. Merging this PR fixes #782

see also: https://api.slack.com/admins/audit-logs

Category (place an x in each of the [ ])

  • slack_sdk.audit_logs (sync/async) (Audit Logs API client)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality Version: 3x labels Jan 30, 2021
@seratch seratch added this to the 3.3.0 milestone Jan 30, 2021
@seratch seratch self-assigned this Jan 30, 2021
@codecov
Copy link

codecov bot commented Jan 30, 2021 •
edited
Loading

Codecov Report

Merging #936 (c11cf3e) into main (a8d709b) will decrease coverage by 0.40%.
The diff coverage is 81.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   86.46%   86.06%   -0.41%     
==========================================
  Files          51       57       +6     
  Lines        4619     4995     +376     
==========================================
+ Hits         3994     4299     +305     
- Misses        625      696      +71
Impacted Files Coverage Δ
slack_sdk/audit_logs/v1/logs.py 76.53% <76.53%> (ø)
slack_sdk/audit_logs/v1/client.py 77.77% <77.77%> (ø)
slack_sdk/audit_logs/v1/async_client.py 89.33% <89.33%> (ø)
slack_sdk/audit_logs/v1/internal_utils.py 90.47% <90.47%> (ø)
slack_sdk/audit_logs/async_client.py 100.00% <100.00%> (ø)
slack_sdk/audit_logs/v1/response.py 100.00% <100.00%> (ø)
slack_sdk/socket_mode/builtin/internals.py 81.54% <0.00%> (-0.60%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d709b...c11cf3e. Read the comment docs.

@seratch seratch mentioned this pull request Feb 1, 2021
Closed
3 tasks
@seratch
Copy link
Contributor Author

seratch commented Feb 2, 2021

@mwbrooks Thanks for your review 👍

@seratch seratch merged commit b79dd77 into slackapi:main Feb 2, 2021
@seratch seratch deleted the issue-782-audit-logs branch February 2, 2021 05:26
This was referenced Feb 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@stevengill stevengill Awaiting requested review from stevengill

@misscoded misscoded Awaiting requested review from misscoded

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality Version: 3x

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

Audit Logs API support

2 participants

@seratch @mwbrooks