Skip to content

Add aiohttp version validation (ref #912) #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seratch merged 1 commit into from
Jan 12, 2021
Merged

Add aiohttp version validation (ref #912) #914

seratch merged 1 commit into from
Jan 12, 2021

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Jan 12, 2021

Summary

This pull request adds aiohttp library validator to prevent the situation like #912 happening to many developers. After merging this PR, I will apply the same validation to Socket Mode client based on aiohttp in #883

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (Web API client)
  • slack_sdk.webhook.WebhookClient (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.rtm.RTMClient (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added this to the 3.2.0 milestone Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #914 (0d06add) into main (e05af1f) will increase coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #914   +/-   ##
=======================================
  Coverage   87.94%   87.95%           
=======================================
  Files          35       36    +1     
  Lines        3385     3396   +11     
=======================================
+ Hits         2977     2987   +10     
- Misses        408      409    +1
Impacted Files Coverage Δ
slack_sdk/aiohttp_version_checker.py 90.90% <90.90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e05af1f...0d06add. Read the comment docs.

@seratch seratch requested review from aoberoi and stevengill January 12, 2021 10:09
@seratch seratch merged commit 3e37278 into slackapi:main Jan 12, 2021
@seratch seratch deleted the aiohttp-version branch January 12, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevengill stevengill Awaiting requested review from stevengill

@aoberoi aoberoi Awaiting requested review from aoberoi

Assignees

No one assigned

Labels

dependency-side-issue rtm-client Version: 3x

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

1 participant

@seratch