Fix #705 by modifying SlackResponse to consider None value in dict#706
Merged
seratch merged 1 commit intoslackapi:masterfrom May 28, 2020
Merged
Conversation
seratch
added
Version: 2x
bug
Contributor
Author
|
@stevengill @aoberoi |
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 85.66% 85.68% +0.02%
==========================================
Files 19 19
Lines 2630 2634 +4
Branches 251 252 +1
==========================================
+ Hits 2253 2257 +4
Misses 282 282
Partials 95 95
Continue to review full report at Codecov.
|
stevengill
approved these changes
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #705 by modifying
SlackRepsonseto consider possible None values inreq_argsdict.Requirements (place an
xin each[ ])