Fix #611 - stop propagating user exceptions to the connection management layer#679
Merged
seratch merged 1 commit intoslackapi:masterfrom May 14, 2020
Merged
Fix #611 - stop propagating user exceptions to the connection management layer#679seratch merged 1 commit intoslackapi:masterfrom
seratch merged 1 commit intoslackapi:masterfrom
Conversation
seratch
added
Version: 2x
bug
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
- Coverage 86.92% 86.76% -0.17%
==========================================
Files 16 16
Lines 1889 1896 +7
Branches 126 126
==========================================
+ Hits 1642 1645 +3
- Misses 210 214 +4
Partials 37 37
Continue to review full report at Codecov.
|
… management layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#665 had a dependency on #662 but the fix can be independent. This pull request brings the only necessary changes for fixing #661
This pull request fixes #611 by stopping the propagation of user exceptions to
_connect_and_read()method. Raised exceptions to_connect_and_read()results in WebSocket connection closure. That is not intended in the scenarios where developers don't handle (or forget handling) exceptions in their methods decorated by@RTMClient.run_on.You can verify the validity of this change by running an integration test: https://github.com/slackapi/python-slackclient/blob/master/integration_tests/rtm/test_issue_611.py
Requirements (place an
xin each[ ])