Update BlockAttachment to not send invalid JSON due to fields attribute #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I started using 2.1.0 internally and immediately ran into this 🤦♂️ |
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 69.58% 69.94% +0.35%
==========================================
Files 15 15
Lines 1654 1657 +3
Branches 91 91
==========================================
+ Hits 1151 1159 +8
+ Misses 481 476 -5
Partials 22 22
Continue to review full report at Codecov.
|
Contributor
|
Thanks for your diligence Paul! |
RodneyU215
added
Priority: High
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in #400; the base Attachment class that BlockAttachment inherits from will populate the
fieldsattribute with an empty list, which then gets sent in the JSON to Slack. That makes the JSON invalid, meaning the BlockAttachment class as it is now cannot be used without manually adjusting the JSON/dict returned.This PR updates the class, as well as adds a test that would have caught this.
Requirements (place an
xin each[ ])