Skip to content

Fixing bugs that were recently introduced in master #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RodneyU215 merged 2 commits into from
Jul 1, 2019
Merged

Fixing bugs that were recently introduced in master #466

RodneyU215 merged 2 commits into from
Jul 1, 2019

Conversation

@RodneyU215
Copy link
Contributor

@RodneyU215 RodneyU215 commented Jun 29, 2019

Summary

RTMClient:

  1. Updated the send_over_websocket method to use the same event loop.
  2. Added back a method _execute_in_thread to executescallbacks in a separate thread for non-async methods.

WebClient:

  1. Fix a bug where we incorrectly created a new event loop regardless if there was already a loop running.
  2. Added charset to the headers to prevent the missing charset warning from Slack.
  3. Refactored how we opened and closed files because the file has to be open while it's being transported.
  4. Added a Future return type to the Web API methods.

Other updates:

  1. Updated ReadMe to include details around how to install optional extras.
  2. Added optional headers attributes to the RTM and Web clients.
  3. Minor test updates.

Requirements

@RodneyU215 RodneyU215 self-assigned this Jun 29, 2019
@RodneyU215 RodneyU215 added Priority: High bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x labels Jun 29, 2019
@RodneyU215 RodneyU215 mentioned this pull request Jun 29, 2019
Closed
2 tasks
@codecov
Copy link

codecov bot commented Jun 29, 2019 •
edited
Loading

Codecov Report

Merging #466 into master will increase coverage by 0.24%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   69.33%   69.58%   +0.24%     
==========================================
  Files          15       15              
  Lines        1634     1654      +20     
  Branches       90       91       +1     
==========================================
+ Hits         1133     1151      +18     
- Misses        479      481       +2     
  Partials       22       22
Impacted Files Coverage Δ
slack/rtm/client.py 84.15% <100%> (+0.81%) ⬆️
slack/web/client.py 33.87% <100%> (+0.15%) ⬆️
slack/web/base_client.py 81.44% <80.76%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66017f3...f2b823b. Read the comment docs.

@RodneyU215 RodneyU215 mentioned this pull request Jun 30, 2019
Merged
2 tasks
@RodneyU215 RodneyU215 merged commit 863e1d3 into master Jul 1, 2019
@RodneyU215 RodneyU215 mentioned this pull request Jul 1, 2019
Closed
@RodneyU215 RodneyU215 deleted the RU_bug_fixing branch October 29, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@RodneyU215 RodneyU215

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RodneyU215