Skip to content

Conversation

@c-goosen
Copy link
Contributor

Summary

Related to issue: 429

This PR is to enable the use of aiohttp and the existing event loop in a framework like jupyter notebook or sanic framework.

Slack Client is using another event loop, not using the parent loop.

Modified running task async and aiohttp library to automatically detect event loop.

Tested

Within framework sanic

With uvloop

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #448 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   56.94%   56.94%           
=======================================
  Files           6        6           
  Lines         734      734           
  Branches       42       42           
=======================================
  Hits          418      418           
  Misses        307      307           
  Partials        9        9
Impacted Files Coverage Δ
slack/web/base_client.py 84.41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedbadc...648ad24. Read the comment docs.

@RodneyU215 RodneyU215 self-requested a review June 20, 2019 06:58
@RodneyU215 RodneyU215 self-assigned this Jun 20, 2019
@RodneyU215 RodneyU215 added Priority: High bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x labels Jun 20, 2019
@RodneyU215
Copy link
Contributor

Thanks for the PR @c-goosen! I'd like to test a few things before merging this PR, but I'm hoping to get to this very soon.

@RodneyU215 RodneyU215 assigned c-goosen and unassigned RodneyU215 Jun 20, 2019
@c-goosen
Copy link
Contributor Author

@RodneyU215 no problem. Let me know if you need any help or additional tests. I've run into this a couple of times. I am going to do an additional PR for documentation around async and this library.

@c-goosen
Copy link
Contributor Author

@RodneyU215 also if it helps, this is running in my infra already, going to prod in the next couple of days, I am pretty sure from my side that it works.

@RodneyU215
Copy link
Contributor

RodneyU215 commented Jun 29, 2019

@c-goosen Thanks for this PR and for helping to triage #429. It's led me to uncover a deeper issue with how I initially implemented the interactions with the event loop. I do not believe this particular change will be necessary once #466 is merged. Please take a look if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants