Update setup.py #440
Merged
Update setup.py #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
=======================================
Coverage 56.94% 56.94%
=======================================
Files 6 6
Lines 734 734
Branches 42 42
=======================================
Hits 418 418
Misses 307 307
Partials 9 9Continue to review full report at Codecov.
|
RodneyU215
added
Priority: Medium
enhancement
RodneyU215
approved these changes
Jun 13, 2019
Contributor
RodneyU215
left a comment
RodneyU215
left a comment
There was a problem hiding this comment.
This is exactly what we need! Thank you!
c-goosen
pushed a commit
to c-goosen/python-slackclient
that referenced
this pull request
Jun 18, 2019
Update setup.py (slackapi#440)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quick fix for issue #433. It transforms install_requires of aiodns into extras_require.
Reference documentation: https://setuptools.readthedocs.io/en/latest/setuptools.html
Requirements (place an
xin each[ ])