Skip to content

Conversation

@lavabyrd
Copy link

There was a typo in the method name for chat.ScheduleMessage as it was in as chat.ScheduledMessage. Updated and confirmed the other Scheduled API endpoints are correct

@lavabyrd lavabyrd added the bug label May 28, 2019
@lavabyrd lavabyrd requested a review from RodneyU215 May 28, 2019 14:05
@lavabyrd lavabyrd self-assigned this May 28, 2019
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #428 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   56.94%   56.94%           
=======================================
  Files           6        6           
  Lines         734      734           
  Branches       42       42           
=======================================
  Hits          418      418           
  Misses        307      307           
  Partials        9        9
Impacted Files Coverage Δ
slack/web/client.py 33.64% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4594f...e498be5. Read the comment docs.

Copy link
Contributor

@RodneyU215 RodneyU215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn, I missed this too. Thanks!

@lavabyrd lavabyrd merged commit 294aa67 into master May 28, 2019
@lavabyrd lavabyrd deleted the mpreston/scheduled_message_fix branch May 28, 2019 18:56
@lavabyrd lavabyrd restored the mpreston/scheduled_message_fix branch June 6, 2019 10:51
lavabyrd pushed a commit that referenced this pull request Jun 6, 2019
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
@RodneyU215 RodneyU215 mentioned this pull request Jul 1, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants