Skip to content

Remove obsolete missing RTM API support from FAQ#361

Merged
aoberoi merged 2 commits intoslackapi:masterfrom
revolter:patch-1
Jan 3, 2019
Merged

Remove obsolete missing RTM API support from FAQ#361
aoberoi merged 2 commits intoslackapi:masterfrom
revolter:patch-1

Conversation

@revolter
Copy link
Contributor

Summary

Fixes #360.

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2018

CLA assistant check
All committers have signed the CLA.

docs-src/faq.rst Outdated

On the other hand, |product_name| does not provide access to the RTM or Events bot-building APIs, although we anticipate
adding support for these in the future.
On the other hand, |product_name| does not provide access to the Events bot-building API, although we anticipate adding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be good to add a reference to the official Events API package, now that its built?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So besides the RTM being now supported, the Events API is now supported too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not supported with this pacakge, but the slackeventsapi package is another official one that people might want to know about.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aoberoi
Copy link
Contributor

aoberoi commented Dec 12, 2018

🤔 I wonder why the tests are failing here but are okay on master? there don't seem to be any code changes in this PR.

@revolter
Copy link
Contributor Author

Most probably because they were failing on master when I branched off. I could do a rebase to fix them.

@revolter
Copy link
Contributor Author

Actually, even master is failing.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #361 into master will decrease coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
- Coverage   76.38%   75.66%   -0.73%     
==========================================
  Files          10       10              
  Lines         415      415              
  Branches       74       73       -1     
==========================================
- Hits          317      314       -3     
- Misses         87       90       +3     
  Partials       11       11
Impacted Files Coverage Δ
slackclient/user.py 59.09% <0%> (-9.1%) ⬇️
slackclient/client.py 65.62% <0%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87630df...28f8856. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #361 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files          10       10           
  Lines         415      415           
  Branches       74       74           
=======================================
  Hits          317      317           
  Misses         87       87           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc215a...942b06a. Read the comment docs.

@revolter
Copy link
Contributor Author

Don't know if I chose the right wording though.

@aoberoi
Copy link
Contributor

aoberoi commented Dec 17, 2018

Hopefully now that #366 has landed, all you need to do is update this branch to see this one pass as well. @revolter I think you'll need to do that on your end.

@revolter
Copy link
Contributor Author

That was my plan too, will do later.

@revolter
Copy link
Contributor Author

revolter commented Jan 2, 2019

@aoberoi, Rebased it.

@aoberoi
Copy link
Contributor

aoberoi commented Jan 3, 2019

🤔 Not sure why appveyor is having trouble reporting its status check, but since its not relevant to these changes, i'm fine using my admin rights to merge this.

thanks @revolter for sticking with this!

@aoberoi aoberoi merged commit a1f423c into slackapi:master Jan 3, 2019
@revolter
Copy link
Contributor Author

revolter commented Jan 3, 2019

Sorry for the delay though!

@revolter revolter deleted the patch-1 branch January 3, 2019 14:05
lavabyrd pushed a commit that referenced this pull request Apr 25, 2019
Remove obsolete missing RTM API support from FAQ
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
Remove obsolete missing RTM API support from FAQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants