Add http reply into slack login and slack connection error#216
Merged
Roach merged 1 commit intoslackapi:masterfrom Oct 9, 2017
Merged
Add http reply into slack login and slack connection error#216Roach merged 1 commit intoslackapi:masterfrom
Roach merged 1 commit intoslackapi:masterfrom
Conversation
It is quite useful to have these exceptions contain the reply that caused the failure (especially for example when checking for a 429 status code and backing off further requests). Right now it is impossible to determine what the underlying issue was and react appropriatly to it.
|
|
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 61.84% 62.33% +0.49%
==========================================
Files 9 9
Lines 304 308 +4
Branches 56 56
==========================================
+ Hits 188 192 +4
Misses 102 102
Partials 14 14
Continue to review full report at Codecov.
|
Roach
approved these changes
Oct 3, 2017
Roach
approved these changes
Oct 3, 2017
c-goosen
pushed a commit
to c-goosen/python-slackclient
that referenced
this pull request
Jun 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It is quite useful to have these exceptions contain the reply
that caused the failure (especially for example when checking
for a 429 status code and backing off further requests). Right
now it is impossible to determine what the underlying issue
was and react appropriatly to it.
Requirements (place an
xin each[ ])