include email as user property#173
Merged
Roach merged 1 commit intoslackapi:masterfrom Nov 16, 2017
acaire:master
Merged
Conversation
Contributor
acaire
commented
Mar 8, 2017
acaire
commented
- I've read and understood the Contributing guidelines and have done my best effort to follow them.
- I've read and agree to the Code of Conduct.
- I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
- I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
- I've written tests to cover the new code and functionality included in this PR.
- I've read, agree to, and signed the Contributor License Agreement (CLA).
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
==========================================
- Coverage 59.87% 59.62% -0.26%
==========================================
Files 9 9
Lines 314 317 +3
Branches 57 58 +1
==========================================
+ Hits 188 189 +1
- Misses 112 113 +1
- Partials 14 15 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
@Roach, anything I can do to help move this along? :) |
Roach
approved these changes
Nov 16, 2017
lavabyrd
pushed a commit
that referenced
this pull request
Apr 25, 2019
c-goosen
pushed a commit
to c-goosen/python-slackclient
that referenced
this pull request
Jun 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.