Skip to content

Remove an extra word in CONTRIBUTING#142

Merged
Roach merged 2 commits intoslackapi:masterfrom
nedbat:fix-contributing
Nov 26, 2016
Merged

Remove an extra word in CONTRIBUTING#142
Roach merged 2 commits intoslackapi:masterfrom
nedbat:fix-contributing

Conversation

@nedbat
Copy link
Contributor

@nedbat nedbat commented Nov 17, 2016

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Fix a simple typo.

Test strategy

Read the file :)

@codecov-io
Copy link

codecov-io commented Nov 17, 2016

Current coverage is 61.56% (diff: 100%)

Merging #142 into master will not change coverage

@@             master       #142   diff @@
==========================================
  Files             8          8          
  Lines           255        255          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            157        157          
  Misses           98         98          
  Partials          0          0          

Powered by Codecov. Last update d753df3...9c52bd3

Copy link
Contributor

@Roach Roach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

Thanks, Ned!

@Roach Roach merged commit c7c6866 into slackapi:master Nov 26, 2016
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants