Skip to content

make objects python3 compatible#106

Merged
Yasumoto merged 2 commits intoslackapi:masterfrom
shashankredemption:make_python3_compatible
Jul 6, 2016
Merged

make objects python3 compatible#106
Yasumoto merged 2 commits intoslackapi:masterfrom
shashankredemption:make_python3_compatible

Conversation

@shashankredemption
Copy link

@shashankredemption shashankredemption commented Jul 6, 2016

In python 3, objects with __eq__ methods need __hash__ methods. Thus, here we write __hash__ methods for the objects we have that were previously not hashable.

@coveralls
Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage increased (+0.04%) to 61.265% when pulling 72affb5 on shashankredemption:make_python3_compatible into fc21a03 on slackhq:master.

@shashankredemption shashankredemption self-assigned this Jul 6, 2016
@coveralls
Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage increased (+0.04%) to 61.265% when pulling dc8c486 on shashankredemption:make_python3_compatible into fc21a03 on slackhq:master.

@Yasumoto Yasumoto merged commit 18cb7ca into slackapi:master Jul 6, 2016
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
…compatible

make objects python3 compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants