Skip to content

Sync client swallows auth errors #530

@Gastove

Description

@Gastove

Description

When given an invalid bot token, the RTM client just... sits there. No error is raised; no output is provided that something is wrong, unless the log level is set to debug, in which case the problem becomes clearly visible:

The server responded with: {'ok': False, 'error': 'invalid_auth'}

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

slackclient version: slackclient==2.2.0

python version: 3.7.4

OS version(s): Fedora 30

Steps to reproduce:

  1. Start the RTM client with an invalid token:
rtm_client = slack.RTMClient(token="I am not a token")
rtm_client.start()

Expected result:

I should get a runtime exception of some form, indicating my token is bad.

Actual result:

The client simply runs for as long as I'll let it, with no output of any kind. If I set log level to debug, the API is clearly telling the client about the problem:

The server responded with: {'ok': False, 'error': 'invalid_auth'}

Metadata

Metadata

Assignees

No one assigned

    Labels

    Version: 2xbugM-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documentedrtm-client

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions