Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: slackapi/python-slack-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: slackapi/python-slack-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix/chat-stream-stop-chunks
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 4 files changed
  • 2 contributors

Commits on Mar 4, 2026

  1. fix: eagerly start chat stream on first append and forward chunks in … 

    …stop

The ChatStream helper had two buffering bugs:

1. append() deferred calling chat.startStream until the buffer reached
   256 characters or chunks were provided. This meant short incremental
   text appends would never start the stream, so Slack had no message to
   render and the streaming indicator would not appear until stop().

2. stop() called chat.startStream without forwarding the buffered text
   or chunks. Content was only sent with the subsequent chat.stopStream
   call, so users would see nothing until the stream completed.

Fix (1) by adding a `not self._stream_ts` check to the flush condition
in append(), ensuring the very first append always triggers startStream.
Fix (2) by delegating to _flush_buffer() in stop() instead of calling
chat.startStream directly.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
    @mcodik
    mcodik and Claude committed Mar 4, 2026
    Configuration menu
    Copy the full SHA
    e4a4a6f View commit details
    Browse the repository at this point in the history
Loading