Skip to content

Fix #53 by removing python 2.7.6 from TravisCI builds #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 2 commits into from
Jun 10, 2020
Merged

Fix #53 by removing python 2.7.6 from TravisCI builds #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e795ba6
Fix #53 by removing python 2.7.6 from TravisCI builds
seratch Jun 4, 2020
c7dbaa1
Fix broken builds
seratch Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ tests/.cache
.coverage
.cache
.DS_Store
.vscode/
.eggs/
build/
4 changes: 1 addition & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
sudo: false
dist: trusty
language: python
python:
- "2.7.6"
- "2.7"
- "3.4"
- "3.5"
Expand All @@ -15,4 +13,4 @@ script:
- flake8 slackeventsapi
- py.test --cov-report= --cov=slackeventsapi tests
after_success:
- codecov -e $TRAVIS_PYTHON_VERSION
- codecov -e $TRAVIS_PYTHON_VERSION
5 changes: 3 additions & 2 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
coveralls==1.1
ipdb==0.9.3
ipython==4.1.2
pdbpp==0.8.3
pdbpp==0.10.2
pytest>=3.2.0,<4.0.0
pytest-flask==0.10.0
pytest-mock>=1.6.3
pytest-cov==2.5.1
pytest-pythonpath==0.7.1
testfixtures==5.3.1
tox==2.9.1
tox==2.9.1
werkzeug==0.16.1
Copy link
Contributor Author

@seratch seratch Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a quick (and tentative) fix for ImportError: cannot import name 'cached_property' from 'werkzeug' (incompatibility with werkzeug 1.0), which is not an issue of this library.

see also: jarus/flask-testing#143

Copy link
Contributor

@aoberoi aoberoi Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is werkzeug a transitive dependency through some other dependency? I'm not sure how this affected our package.

Copy link
Contributor Author

@seratch seratch Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aoberoi
Flask depends on werkzeug. Flask's project setting has been declaring it is compatible with Werkzeug>=0.15 for a long time.

As mentioned above (and also you can see the actual failure here), werkzeug 1.0 is incompatible with 0.16 or older as it has removed cached_property module.

As far as I know, the breaking change affects only tests with Flask. I haven't found any issues with production apps yet. I will verify if there is really no issue. I'm going to check which versions of Flask this package should support soon in regards to #58

On the assumption that the breaking change doesn't directly affect this package, I just applied a quick fix to run tests with werkzeug 0.16. In my observation, it's safe enough.

Does this make sense to you?

Copy link
Contributor Author

@seratch seratch Jun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#72 removed this limitation